From d8ad4e902cd359cf0a58cc8fc759377ec3d3c026 Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 13 Aug 2019 14:15:14 +0200 Subject: meta: convert workflow file to GitHub Actions v2 yml syntax --- .github/main.workflow | 17 ----------------- .github/workflows/pull_request_triage.yml | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 17 deletions(-) delete mode 100644 .github/main.workflow create mode 100644 .github/workflows/pull_request_triage.yml (limited to '.github') diff --git a/.github/main.workflow b/.github/main.workflow deleted file mode 100644 index 0dbb0247a..000000000 --- a/.github/main.workflow +++ /dev/null @@ -1,17 +0,0 @@ -workflow "Triage Pull Request" { - on = "pull_request" - resolves = ["Triage"] -} - -# Only act if there are code changes: if the pull_request -# event's action is either 'opened' (new PR) or 'synchronize' (new commits) -action "Filter actions" { - uses = "actions/bin/filter@0ac6d44" - args = "action 'opened|synchronize'" -} - -action "Triage" { - needs = ["Filter actions"] - uses = "ohmyzsh/github-actions/pull-request-triage@master" - secrets = ["GITHUB_TOKEN"] -} diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml new file mode 100644 index 000000000..341298a0f --- /dev/null +++ b/.github/workflows/pull_request_triage.yml @@ -0,0 +1,14 @@ +on: pull_request +name: Triage Pull Request +jobs: + mainJob: + name: Triage + if: github.event.action == 'opened' || github.event.action == 'synchronize' + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@master + - name: Analyze and triage + uses: ohmyzsh/github-actions/pull-request-triage@master + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -- cgit v1.2.3-70-g09d2 From 4974143745360bfbfde535eab23df27daa8e3c8f Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 13 Aug 2019 15:10:15 +0200 Subject: meta: move if condition on workflow to steps Provisional measure due to "Unexpected value 'if'" error. See https://github.community/t5/GitHub-API-Development-and/jobs-lt-job-id-gt-if-not-working/m-p/28980 --- .github/workflows/pull_request_triage.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml index 341298a0f..a27392a92 100644 --- a/.github/workflows/pull_request_triage.yml +++ b/.github/workflows/pull_request_triage.yml @@ -1,13 +1,13 @@ on: pull_request name: Triage Pull Request jobs: - mainJob: + triage: name: Triage - if: github.event.action == 'opened' || github.event.action == 'synchronize' runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@master + if: github.event.action == 'opened' || github.event.action == 'synchronize' - name: Analyze and triage uses: ohmyzsh/github-actions/pull-request-triage@master env: -- cgit v1.2.3-70-g09d2 From c4c620adcd0dadf8f3f0d6aa331780291b5bdacd Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Sun, 18 Aug 2019 15:13:46 +0200 Subject: meta: add DEBUG_ACTIONS flag to PR triage action --- .github/workflows/pull_request_triage.yml | 1 + 1 file changed, 1 insertion(+) (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml index a27392a92..77ec4ce79 100644 --- a/.github/workflows/pull_request_triage.yml +++ b/.github/workflows/pull_request_triage.yml @@ -12,3 +12,4 @@ jobs: uses: ohmyzsh/github-actions/pull-request-triage@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + DEBUG_ACTIONS: ${{ secrets.DEBUG_ACTIONS }} -- cgit v1.2.3-70-g09d2 From a4f6a9964ceec3d222a8caa8eb3e5cf6027cfbab Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 3 Sep 2019 21:19:38 +0200 Subject: meta: remove PR triage GitHub action :cry: We do this because the GitHub Actions behavior was changed recently so as to not pass secrets to action runs started from forks, therefore the API token passed cannot be used to change PR labels. There may be an alternative in the future. --- .github/workflows/pull_request_triage.yml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/pull_request_triage.yml (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml deleted file mode 100644 index 77ec4ce79..000000000 --- a/.github/workflows/pull_request_triage.yml +++ /dev/null @@ -1,15 +0,0 @@ -on: pull_request -name: Triage Pull Request -jobs: - triage: - name: Triage - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@master - if: github.event.action == 'opened' || github.event.action == 'synchronize' - - name: Analyze and triage - uses: ohmyzsh/github-actions/pull-request-triage@master - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DEBUG_ACTIONS: ${{ secrets.DEBUG_ACTIONS }} -- cgit v1.2.3-70-g09d2 From ca6b3977834889f56d03356061394ca80f3520c6 Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 15 Oct 2019 22:56:45 +0200 Subject: meta: remove automatic bug label on bug reports People sometimes use the bug report template for things that are support. Maintainers will confirm whether it's a bug with the appropriate label. --- .github/ISSUE_TEMPLATE/bug_report.md | 1 - 1 file changed, 1 deletion(-) (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index ff55f36be..076c35544 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,7 +1,6 @@ --- name: Bug report about: Create a report to help us improve -labels: 'Type: bug' --- -- cgit v1.2.3-70-g09d2 From 64a7f6b38833d007394b9b4bf5d17e48db77c0d7 Mon Sep 17 00:00:00 2001 From: Modded Gamers <35778371+ModdedGamers@users.noreply.github.com> Date: Tue, 28 Jan 2020 18:22:27 -0500 Subject: Create Github Action to run tests (#8569) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The published workflow tests the installer and checks the syntax of known zsh files in the project. Co-authored-by: Marc Cornellà --- .github/workflows/check-suite.yml | 36 ++++++++++++++++++++++++++++++++++++ README.md | 1 + 2 files changed, 37 insertions(+) create mode 100644 .github/workflows/check-suite.yml (limited to '.github') diff --git a/.github/workflows/check-suite.yml b/.github/workflows/check-suite.yml new file mode 100644 index 000000000..3a7ad354d --- /dev/null +++ b/.github/workflows/check-suite.yml @@ -0,0 +1,36 @@ +name: Check Suite +on: + pull_request: + types: + - opened + - synchronize + branches: + - master + push: + branches: + - master + +jobs: + tests: + name: Run tests + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, macos-latest] + steps: + - name: Set up git repository + uses: actions/checkout@v2 + - name: Install zsh + if: runner.os == 'Linux' + run: sudo apt-get update; sudo apt-get install zsh + - name: Test installer + run: sh ./tools/install.sh + - name: Check syntax + run: | + for file in ./oh-my-zsh.sh \ + ./lib/*.zsh \ + ./plugins/*/*.plugin.zsh \ + ./plugins/*/_* \ + ./themes/*.zsh-theme; do + zsh -n "$file" || return 1 + done diff --git a/README.md b/README.md index 291fb512b..fddc7c241 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,7 @@ Finally, you'll begin to get the sort of attention that you have always felt you To learn more, visit [ohmyz.sh](https://ohmyz.sh), follow [@ohmyzsh](https://twitter.com/ohmyzsh) on Twitter, and/or join us on Discord. +![Check Suite](https://github.com/ohmyzsh/ohmyzsh/workflows/Check%20Suite/badge.svg) [![Follow @ohmyzsh](https://img.shields.io/twitter/follow/ohmyzsh?label=Follow+@ohmyzsh&style=flat)](https://twitter.com/intent/follow?screen_name=ohmyzsh) [![Discord server](https://img.shields.io/discord/642496866407284746)](https://discord.gg/bpXWhnN) -- cgit v1.2.3-70-g09d2 From df56d1ee1fb7430d8979973300bf0c6b53a5446c Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 4 Feb 2020 13:02:20 +0100 Subject: Rename GitHub Action to CI --- .github/workflows/check-suite.yml | 36 ------------------------------------ .github/workflows/main.yml | 36 ++++++++++++++++++++++++++++++++++++ README.md | 2 +- 3 files changed, 37 insertions(+), 37 deletions(-) delete mode 100644 .github/workflows/check-suite.yml create mode 100644 .github/workflows/main.yml (limited to '.github') diff --git a/.github/workflows/check-suite.yml b/.github/workflows/check-suite.yml deleted file mode 100644 index 3a7ad354d..000000000 --- a/.github/workflows/check-suite.yml +++ /dev/null @@ -1,36 +0,0 @@ -name: Check Suite -on: - pull_request: - types: - - opened - - synchronize - branches: - - master - push: - branches: - - master - -jobs: - tests: - name: Run tests - runs-on: ${{ matrix.os }} - strategy: - matrix: - os: [ubuntu-latest, macos-latest] - steps: - - name: Set up git repository - uses: actions/checkout@v2 - - name: Install zsh - if: runner.os == 'Linux' - run: sudo apt-get update; sudo apt-get install zsh - - name: Test installer - run: sh ./tools/install.sh - - name: Check syntax - run: | - for file in ./oh-my-zsh.sh \ - ./lib/*.zsh \ - ./plugins/*/*.plugin.zsh \ - ./plugins/*/_* \ - ./themes/*.zsh-theme; do - zsh -n "$file" || return 1 - done diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 000000000..7ab7efdd6 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,36 @@ +name: CI +on: + pull_request: + types: + - opened + - synchronize + branches: + - master + push: + branches: + - master + +jobs: + tests: + name: Run tests + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, macos-latest] + steps: + - name: Set up git repository + uses: actions/checkout@v2 + - name: Install zsh + if: runner.os == 'Linux' + run: sudo apt-get update; sudo apt-get install zsh + - name: Test installer + run: sh ./tools/install.sh + - name: Check syntax + run: | + for file in ./oh-my-zsh.sh \ + ./lib/*.zsh \ + ./plugins/*/*.plugin.zsh \ + ./plugins/*/_* \ + ./themes/*.zsh-theme; do + zsh -n "$file" || return 1 + done diff --git a/README.md b/README.md index fddc7c241..d36591abc 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ Finally, you'll begin to get the sort of attention that you have always felt you To learn more, visit [ohmyz.sh](https://ohmyz.sh), follow [@ohmyzsh](https://twitter.com/ohmyzsh) on Twitter, and/or join us on Discord. -![Check Suite](https://github.com/ohmyzsh/ohmyzsh/workflows/Check%20Suite/badge.svg) +![CI](https://github.com/ohmyzsh/ohmyzsh/workflows/CI/badge.svg) [![Follow @ohmyzsh](https://img.shields.io/twitter/follow/ohmyzsh?label=Follow+@ohmyzsh&style=flat)](https://twitter.com/intent/follow?screen_name=ohmyzsh) [![Discord server](https://img.shields.io/discord/642496866407284746)](https://discord.gg/bpXWhnN) -- cgit v1.2.3-70-g09d2 From beab76edfce3500b2fb357c69f3d4fb2a17898fe Mon Sep 17 00:00:00 2001 From: Larson Carter Date: Fri, 13 Dec 2019 08:18:25 -0600 Subject: Update issues and PR templates (#8471) Closes #8471 --- .github/ISSUE_TEMPLATE/bug_report.md | 32 +++++++++++++++---------------- .github/ISSUE_TEMPLATE/feature_request.md | 10 +++++----- .github/ISSUE_TEMPLATE/support.md | 2 -- .github/PULL_REQUEST_TEMPLATE.md | 17 ++++++++++++++++ 4 files changed, 37 insertions(+), 24 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 076c35544..7c1cb8967 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,6 +1,7 @@ --- name: Bug report -about: Create a report to help us improve +about: Create a report to help us improve Oh My Zsh +labels: 'Type: support' --- @@ -10,29 +11,26 @@ an issue where no sections have been filled will be deleted without comment. --> **Describe the bug** - +A clear description of what the bug is. **To Reproduce** - **Expected behavior** - +A brief description of what should happen. -**Screenshots or recordings** - +**Screenshots and/or Recordings** +If applicable, add screenshots to help explain your problem. +You can also record an asciinema session: https://asciinema.org/ -**System:** - - OS: [e.g. macOS] - - Zsh version [e.g. 5.6] +**Desktop (please complete the following information):** + - OS / Distro: [e.g. Arch Linux, macOS] + - Latest ohmyzsh Update?: [e.g. Yes/No] + - ZSH Version: [e.g. 5.6] - Terminal emulator [e.g. iTerm2] **Additional context** - +Add any other context about the problem here. This can be themes, plugins, custom configs. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index d9c324a55..346eabaea 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -11,16 +11,16 @@ an issue where no sections have been filled will be deleted without comment. --> **Is your feature request related to a particular plugin or theme? If so, specify it.** - +The name of the plugin or theme that you would like us to improve. [...] **Is your feature request related to a problem? Please describe.** - +A description of what the problem is. Ex. I'm always frustrated when [...] **Describe the solution you'd like** - +A description of what you want to happen. **Describe alternatives you've considered** - +A description of any alternative solutions or features you've considered. This can also include other plugins or aliases. **Additional context** - +Add any other context or screenshots about the feature request here. Also if you have any PRs related to this issue that are already open that you would like us to look at. diff --git a/.github/ISSUE_TEMPLATE/support.md b/.github/ISSUE_TEMPLATE/support.md index 3c69a7d5e..d2638412e 100644 --- a/.github/ISSUE_TEMPLATE/support.md +++ b/.github/ISSUE_TEMPLATE/support.md @@ -5,8 +5,6 @@ labels: 'Type: support' --- - diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..6bcb90efe --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,17 @@ +## Standards checklist: + +- [ ] The PR title is descriptive. +- [ ] The PR doesn't replicate another PR which is already open. +- [ ] I have read the contribution guide and followed all the instructions. +- [ ] The code follows the code style guide detailed in the wiki. +- [ ] The code is mine or it's from somewhere with an MIT-compatible license. +- [ ] The code is efficient, to the best of my ability, and does not waste computer resources. +- [ ] The code is stable and I have tested it myself, to the best of my abilities. + +## Changes: + +- [...] + +## Other comments: + +... -- cgit v1.2.3-70-g09d2