From 8113ed065d5bead01430e393bd33d6e32a597471 Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Fri, 3 May 2019 16:31:22 +0200 Subject: Add GitHub Action to label Pull Requests --- .github/main.workflow | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/main.workflow (limited to '.github') diff --git a/.github/main.workflow b/.github/main.workflow new file mode 100644 index 000000000..0dbb0247a --- /dev/null +++ b/.github/main.workflow @@ -0,0 +1,17 @@ +workflow "Triage Pull Request" { + on = "pull_request" + resolves = ["Triage"] +} + +# Only act if there are code changes: if the pull_request +# event's action is either 'opened' (new PR) or 'synchronize' (new commits) +action "Filter actions" { + uses = "actions/bin/filter@0ac6d44" + args = "action 'opened|synchronize'" +} + +action "Triage" { + needs = ["Filter actions"] + uses = "ohmyzsh/github-actions/pull-request-triage@master" + secrets = ["GITHUB_TOKEN"] +} -- cgit v1.2.3-70-g09d2 From dfb060f8cfddffbb9700bd6106d25a5c5be0b88f Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Thu, 16 May 2019 21:54:54 +0200 Subject: meta: add initial issue templates This commit adds the following issue categories: - Bug report - Feature request - Support --- .github/ISSUE_TEMPLATE/bug_report.md | 31 +++++++++++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 23 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/support.md | 13 +++++++++++++ 3 files changed, 67 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md create mode 100644 .github/ISSUE_TEMPLATE/support.md (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 000000000..2ac8c3769 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,31 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: 'Type: bug' +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Enable plugin '...' +2. Run command '...', _or_ try to complete command '...', _etc._ +3. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots or recordings** +If applicable, add screenshots or record an [asciinema session](https://asciinema.org/) to help explain your problem. + +**Desktop (please complete the following information):** + - OS: [e.g. macOS] + - Zsh version [e.g. 5.6] + - Terminal emulator [e.g. iTerm2] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 000000000..daabf7940 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,23 @@ +--- +name: Feature request +about: Suggest an idea for Oh My Zsh +title: '' +labels: 'Type: feature request' +assignees: '' + +--- + +**Is your feature request related to a particular plugin or theme? If so, specify it.** +The name of the plugin or theme you'd like us to improve. + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. diff --git a/.github/ISSUE_TEMPLATE/support.md b/.github/ISSUE_TEMPLATE/support.md new file mode 100644 index 000000000..10b614b8f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/support.md @@ -0,0 +1,13 @@ +--- +name: Support +about: Request support for any problem you're having with Oh My Zsh +title: '' +labels: 'Type: support' +assignees: '' + +--- + + -- cgit v1.2.3-70-g09d2 From f62a71e9de3a98438e7d38040f145fe77dfb48de Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 21 May 2019 11:53:52 +0200 Subject: meta: update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 22 +++++++++++++++------- .github/ISSUE_TEMPLATE/feature_request.md | 17 ++++++++++------- .github/ISSUE_TEMPLATE/support.md | 7 +++---- 3 files changed, 28 insertions(+), 18 deletions(-) (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 2ac8c3769..ff55f36be 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,31 +1,39 @@ --- name: Bug report about: Create a report to help us improve -title: '' labels: 'Type: bug' -assignees: '' --- + + **Describe the bug** -A clear and concise description of what the bug is. + **To Reproduce** + **Expected behavior** -A clear and concise description of what you expected to happen. + **Screenshots or recordings** -If applicable, add screenshots or record an [asciinema session](https://asciinema.org/) to help explain your problem. + -**Desktop (please complete the following information):** +**System:** - OS: [e.g. macOS] - Zsh version [e.g. 5.6] - Terminal emulator [e.g. iTerm2] **Additional context** -Add any other context about the problem here. + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index daabf7940..3243e0b0a 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -1,23 +1,26 @@ --- name: Feature request about: Suggest an idea for Oh My Zsh -title: '' labels: 'Type: feature request' -assignees: '' --- + + **Is your feature request related to a particular plugin or theme? If so, specify it.** -The name of the plugin or theme you'd like us to improve. + **Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + **Describe the solution you'd like** -A clear and concise description of what you want to happen. + **Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. + **Additional context** -Add any other context or screenshots about the feature request here. + diff --git a/.github/ISSUE_TEMPLATE/support.md b/.github/ISSUE_TEMPLATE/support.md index 10b614b8f..3c69a7d5e 100644 --- a/.github/ISSUE_TEMPLATE/support.md +++ b/.github/ISSUE_TEMPLATE/support.md @@ -1,13 +1,12 @@ --- name: Support about: Request support for any problem you're having with Oh My Zsh -title: '' labels: 'Type: support' -assignees: '' --- -- cgit v1.2.3-70-g09d2 From 24cd8e8314c1c0ed1bb227dd5d2afda5d471da9a Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Mon, 10 Jun 2019 15:50:25 +0200 Subject: meta: change feature request label --- .github/ISSUE_TEMPLATE/feature_request.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 3243e0b0a..d9c324a55 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -1,7 +1,7 @@ --- name: Feature request -about: Suggest an idea for Oh My Zsh -labels: 'Type: feature request' +about: Suggest a feature for Oh My Zsh +labels: 'Type: feature' --- -- cgit v1.2.3-70-g09d2 From d8ad4e902cd359cf0a58cc8fc759377ec3d3c026 Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 13 Aug 2019 14:15:14 +0200 Subject: meta: convert workflow file to GitHub Actions v2 yml syntax --- .github/main.workflow | 17 ----------------- .github/workflows/pull_request_triage.yml | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 17 deletions(-) delete mode 100644 .github/main.workflow create mode 100644 .github/workflows/pull_request_triage.yml (limited to '.github') diff --git a/.github/main.workflow b/.github/main.workflow deleted file mode 100644 index 0dbb0247a..000000000 --- a/.github/main.workflow +++ /dev/null @@ -1,17 +0,0 @@ -workflow "Triage Pull Request" { - on = "pull_request" - resolves = ["Triage"] -} - -# Only act if there are code changes: if the pull_request -# event's action is either 'opened' (new PR) or 'synchronize' (new commits) -action "Filter actions" { - uses = "actions/bin/filter@0ac6d44" - args = "action 'opened|synchronize'" -} - -action "Triage" { - needs = ["Filter actions"] - uses = "ohmyzsh/github-actions/pull-request-triage@master" - secrets = ["GITHUB_TOKEN"] -} diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml new file mode 100644 index 000000000..341298a0f --- /dev/null +++ b/.github/workflows/pull_request_triage.yml @@ -0,0 +1,14 @@ +on: pull_request +name: Triage Pull Request +jobs: + mainJob: + name: Triage + if: github.event.action == 'opened' || github.event.action == 'synchronize' + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@master + - name: Analyze and triage + uses: ohmyzsh/github-actions/pull-request-triage@master + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -- cgit v1.2.3-70-g09d2 From 4974143745360bfbfde535eab23df27daa8e3c8f Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 13 Aug 2019 15:10:15 +0200 Subject: meta: move if condition on workflow to steps Provisional measure due to "Unexpected value 'if'" error. See https://github.community/t5/GitHub-API-Development-and/jobs-lt-job-id-gt-if-not-working/m-p/28980 --- .github/workflows/pull_request_triage.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml index 341298a0f..a27392a92 100644 --- a/.github/workflows/pull_request_triage.yml +++ b/.github/workflows/pull_request_triage.yml @@ -1,13 +1,13 @@ on: pull_request name: Triage Pull Request jobs: - mainJob: + triage: name: Triage - if: github.event.action == 'opened' || github.event.action == 'synchronize' runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@master + if: github.event.action == 'opened' || github.event.action == 'synchronize' - name: Analyze and triage uses: ohmyzsh/github-actions/pull-request-triage@master env: -- cgit v1.2.3-70-g09d2 From c4c620adcd0dadf8f3f0d6aa331780291b5bdacd Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Sun, 18 Aug 2019 15:13:46 +0200 Subject: meta: add DEBUG_ACTIONS flag to PR triage action --- .github/workflows/pull_request_triage.yml | 1 + 1 file changed, 1 insertion(+) (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml index a27392a92..77ec4ce79 100644 --- a/.github/workflows/pull_request_triage.yml +++ b/.github/workflows/pull_request_triage.yml @@ -12,3 +12,4 @@ jobs: uses: ohmyzsh/github-actions/pull-request-triage@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + DEBUG_ACTIONS: ${{ secrets.DEBUG_ACTIONS }} -- cgit v1.2.3-70-g09d2 From a4f6a9964ceec3d222a8caa8eb3e5cf6027cfbab Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 3 Sep 2019 21:19:38 +0200 Subject: meta: remove PR triage GitHub action :cry: We do this because the GitHub Actions behavior was changed recently so as to not pass secrets to action runs started from forks, therefore the API token passed cannot be used to change PR labels. There may be an alternative in the future. --- .github/workflows/pull_request_triage.yml | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 .github/workflows/pull_request_triage.yml (limited to '.github') diff --git a/.github/workflows/pull_request_triage.yml b/.github/workflows/pull_request_triage.yml deleted file mode 100644 index 77ec4ce79..000000000 --- a/.github/workflows/pull_request_triage.yml +++ /dev/null @@ -1,15 +0,0 @@ -on: pull_request -name: Triage Pull Request -jobs: - triage: - name: Triage - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@master - if: github.event.action == 'opened' || github.event.action == 'synchronize' - - name: Analyze and triage - uses: ohmyzsh/github-actions/pull-request-triage@master - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - DEBUG_ACTIONS: ${{ secrets.DEBUG_ACTIONS }} -- cgit v1.2.3-70-g09d2 From ca6b3977834889f56d03356061394ca80f3520c6 Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Tue, 15 Oct 2019 22:56:45 +0200 Subject: meta: remove automatic bug label on bug reports People sometimes use the bug report template for things that are support. Maintainers will confirm whether it's a bug with the appropriate label. --- .github/ISSUE_TEMPLATE/bug_report.md | 1 - 1 file changed, 1 deletion(-) (limited to '.github') diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index ff55f36be..076c35544 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,7 +1,6 @@ --- name: Bug report about: Create a report to help us improve -labels: 'Type: bug' --- -- cgit v1.2.3-70-g09d2