From 6876d9c5438b0e0e950fc85f736458ba55f8d65c Mon Sep 17 00:00:00 2001 From: Varun Patro Date: Mon, 14 May 2018 19:30:04 +0530 Subject: Update fasd.plugin.zsh (#6822) If `EDITOR` variable contains arguments to an editor such as mine: `export EDITOR=emacsclient -t -c --alternate-editor=''` Then, the editor's arguments are passed on to `fasd`. To fix this, pass the EDITOR program in quotes. --- plugins/fasd/fasd.plugin.zsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/fasd/fasd.plugin.zsh') diff --git a/plugins/fasd/fasd.plugin.zsh b/plugins/fasd/fasd.plugin.zsh index 2c302f74d..45d10858f 100644 --- a/plugins/fasd/fasd.plugin.zsh +++ b/plugins/fasd/fasd.plugin.zsh @@ -6,6 +6,6 @@ if [ $commands[fasd] ]; then # check if fasd is installed source "$fasd_cache" unset fasd_cache - alias v="f -e $EDITOR" + alias v="f -e \"$EDITOR\"" alias o='a -e open_command' fi -- cgit v1.2.3-70-g09d2 From e41699044277c914a280bc9800b45662b01771f1 Mon Sep 17 00:00:00 2001 From: "Cristian Măgherușan-Stanciu @magheru_san" Date: Mon, 3 Sep 2018 17:09:31 +0200 Subject: fasd: drop-in replace the autojump j alias (#3860) --- plugins/fasd/fasd.plugin.zsh | 1 + 1 file changed, 1 insertion(+) (limited to 'plugins/fasd/fasd.plugin.zsh') diff --git a/plugins/fasd/fasd.plugin.zsh b/plugins/fasd/fasd.plugin.zsh index 45d10858f..eaaa96f42 100644 --- a/plugins/fasd/fasd.plugin.zsh +++ b/plugins/fasd/fasd.plugin.zsh @@ -8,4 +8,5 @@ if [ $commands[fasd] ]; then # check if fasd is installed alias v="f -e \"$EDITOR\"" alias o='a -e open_command' + alias j='zz' fi -- cgit v1.2.3-70-g09d2 From 69e637c35578305e19dbfc520e65c514180db6ef Mon Sep 17 00:00:00 2001 From: Marc Cornellà Date: Mon, 3 Sep 2018 17:13:18 +0200 Subject: fasd: use xdg-open in o alias back again Fixes #6314 --- plugins/fasd/fasd.plugin.zsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/fasd/fasd.plugin.zsh') diff --git a/plugins/fasd/fasd.plugin.zsh b/plugins/fasd/fasd.plugin.zsh index eaaa96f42..36a0428a7 100644 --- a/plugins/fasd/fasd.plugin.zsh +++ b/plugins/fasd/fasd.plugin.zsh @@ -7,6 +7,6 @@ if [ $commands[fasd] ]; then # check if fasd is installed unset fasd_cache alias v="f -e \"$EDITOR\"" - alias o='a -e open_command' + alias o='a -e xdg-open' alias j='zz' fi -- cgit v1.2.3-70-g09d2 From 27228d83fe403cf664c0c8626a3874ed3989d084 Mon Sep 17 00:00:00 2001 From: Michael Morgan Date: Sat, 1 Jun 2019 11:40:04 -0700 Subject: fasd: update `v` alias to evaluate $EDITOR lazily (#7900) For the `v` alias to work in its current state, the environment variable EDITOR must already be defined by the time `source $ZSH/oh-my-zsh.sh` happens. However, in the included zshrc template, EDITOR is set from within the "User configuration" section, which begins immediately after the above line. This means that, unless the user knows to move their `export EDITOR` statements, EDITOR will be undefined when fasd.plugin.zsh loads, and therefore the alias will have the value 'f -e ""', preventing it from functioning. With this change, `"$EDITOR"` will be evaluated each time the alias is invoked, instead of just once when the alias is created. This allows for EDITOR to be set from "User configuration" in the zshrc, and has the additional flexibility of allowing a user to specify a different EDITOR for a single session or invocation of the alias. --- plugins/fasd/fasd.plugin.zsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'plugins/fasd/fasd.plugin.zsh') diff --git a/plugins/fasd/fasd.plugin.zsh b/plugins/fasd/fasd.plugin.zsh index 36a0428a7..ec2e5183a 100644 --- a/plugins/fasd/fasd.plugin.zsh +++ b/plugins/fasd/fasd.plugin.zsh @@ -6,7 +6,7 @@ if [ $commands[fasd] ]; then # check if fasd is installed source "$fasd_cache" unset fasd_cache - alias v="f -e \"$EDITOR\"" + alias v='f -e "$EDITOR"' alias o='a -e xdg-open' alias j='zz' fi -- cgit v1.2.3-70-g09d2