From bd38c50241647a1d0b0e2ca49fb1d6b9a2b88806 Mon Sep 17 00:00:00 2001 From: Marc-Antoine Lemieux Date: Mon, 27 May 2013 09:23:14 -0400 Subject: fix the open command in linux using xdg-open --- plugins/jira/jira.plugin.zsh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'plugins/jira') diff --git a/plugins/jira/jira.plugin.zsh b/plugins/jira/jira.plugin.zsh index b91f93c95..bea726a54 100644 --- a/plugins/jira/jira.plugin.zsh +++ b/plugins/jira/jira.plugin.zsh @@ -11,6 +11,13 @@ # Usage: jira # opens a new issue # jira ABC-123 # Opens an existing issue open_jira_issue () { + local open_cmd + if [[ $(uname -s) == 'Darwin' ]]; then + open_cmd='open' + else + open_cmd='xdg-open' + fi + if [ -f .jira-url ]; then jira_url=$(cat .jira-url) elif [ -f ~/.jira-url ]; then @@ -28,9 +35,9 @@ open_jira_issue () { else echo "Opening issue #$1" if [[ "x$JIRA_RAPID_BOARD" = "yes" ]]; then - `open $jira_url/issues/$1` + $open_cmd "$jira_url/issues/$1" else - `open $jira_url/browse/$1` + $open_cmd "$jira_url/browse/$1" fi fi } -- cgit v1.2.3-70-g09d2 From bab1800ded30331b289550b1de8d60bb64f5512f Mon Sep 17 00:00:00 2001 From: Brian Hartvigsen Date: Wed, 12 Jun 2013 12:22:47 -0500 Subject: Correctly detect Rapid Board * Add "x" in front of the value we check against... * Use true instead of yes (more consistent with the rest of ohmyzsh) The fact that no one seems to have raised this as an issue leads me to believe it's not used that much... --- plugins/jira/jira.plugin.zsh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'plugins/jira') diff --git a/plugins/jira/jira.plugin.zsh b/plugins/jira/jira.plugin.zsh index bea726a54..9aa192c1e 100644 --- a/plugins/jira/jira.plugin.zsh +++ b/plugins/jira/jira.plugin.zsh @@ -3,7 +3,7 @@ # .jira-url in the current directory takes precedence # # If you use Rapid Board, set: -#JIRA_RAPID_BOARD="yes" +#JIRA_RAPID_BOARD="true" # in you .zshrc # # Setup: cd to/my/project @@ -34,7 +34,7 @@ open_jira_issue () { `open $jira_url/secure/CreateIssue!default.jspa` else echo "Opening issue #$1" - if [[ "x$JIRA_RAPID_BOARD" = "yes" ]]; then + if [[ "x$JIRA_RAPID_BOARD" = "xtrue" ]]; then $open_cmd "$jira_url/issues/$1" else $open_cmd "$jira_url/browse/$1" -- cgit v1.2.3-70-g09d2