diff options
| author | ncanceill <nicolas.canceill@ens-cachan.org> | 2015-10-16 23:23:38 +0200 |
|---|---|---|
| committer | Marc Cornellà <marc.cornella@live.com> | 2017-03-30 20:32:32 +0200 |
| commit | bc2ccdd812cb90d889f14731896c06c3715876a9 (patch) | |
| tree | 4222bcc16d6bd91d4aa35168b948c30fa4ec1223 /CONTRIBUTING.md | |
| parent | 5a031ce3e67a0e99b6d043aab6034b0532cec26a (diff) | |
| download | zsh-bc2ccdd812cb90d889f14731896c06c3715876a9.tar.gz zsh-bc2ccdd812cb90d889f14731896c06c3715876a9.tar.bz2 zsh-bc2ccdd812cb90d889f14731896c06c3715876a9.zip | |
contributing: improve PR section
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd0d625fa..f86acd66e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -72,11 +72,11 @@ _"Fixes #XXXX"_ for issue number XXXX. ### You have a solution Please be so kind as to [search](#use-the-search-luke) for any open issue already covering -your [problem](#you-have-a-problem), and any pending PR covering your solution. +your [problem](#you-have-a-problem), and any pending/merged/rejected PR covering your solution. If the solution is already reported, try it out and +1 the pull request if the solution works ok. On the other hand, if you think your solution is better, post -it so we can have both solutions to compare. +it with a reference to the other one so we can have both solutions to compare. If not, then go ahead and submit a PR. Please copy to anyone relevant (_eg_ plugin maintainers) by mentioning their GitHub handle (starting with `@`) in your message. @@ -86,7 +86,7 @@ maintainers) by mentioning their GitHub handle (starting with `@`) in your messa Please [do not](https://github.com/robbyrussell/oh-my-zsh/wiki/Themes#dont-send-us-your-theme-for-now) send themes for now. -Please be so kind as to [search](#use-the-search-luke) for any pending PR covering or +Please be so kind as to [search](#use-the-search-luke) for any pending/merged/rejected PR covering or related to what you want to add. If you find one, try it out and work with the author on a common solution. |