diff options
| author | Marc Cornellà <marc.cornella@live.com> | 2015-08-05 00:32:57 +0200 |
|---|---|---|
| committer | Marc Cornellà <marc.cornella@live.com> | 2015-08-05 00:57:40 +0200 |
| commit | d1d06b5675bebbe54f3d876eb993b6e89d8963c7 (patch) | |
| tree | 198d6691cc238fbc61a527a2169b4acbd561d39f /plugins/jira/jira.plugin.zsh | |
| parent | 2d0bfcf81846ea4cb0fe2a42f3dac7f2c60e77b7 (diff) | |
| download | zsh-d1d06b5675bebbe54f3d876eb993b6e89d8963c7.tar.gz zsh-d1d06b5675bebbe54f3d876eb993b6e89d8963c7.tar.bz2 zsh-d1d06b5675bebbe54f3d876eb993b6e89d8963c7.zip | |
Use standard open command in current plugins
Substitutes the current duplicate logic for the standard
and cross-platform function open_command in plugins:
frontend-search, jira, node, web-search
Diffstat (limited to 'plugins/jira/jira.plugin.zsh')
| -rw-r--r-- | plugins/jira/jira.plugin.zsh | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/plugins/jira/jira.plugin.zsh b/plugins/jira/jira.plugin.zsh index ca540c84c..9a8932702 100644 --- a/plugins/jira/jira.plugin.zsh +++ b/plugins/jira/jira.plugin.zsh @@ -11,13 +11,6 @@ # Usage: jira # opens a new issue # jira ABC-123 # Opens an existing issue open_jira_issue () { - local open_cmd - if [[ "$OSTYPE" = darwin* ]]; then - open_cmd='open' - else - open_cmd='xdg-open' - fi - if [ -f .jira-url ]; then jira_url=$(cat .jira-url) elif [ -f ~/.jira-url ]; then @@ -39,7 +32,7 @@ open_jira_issue () { if [ -z "$1" ]; then echo "Opening new issue" - $open_cmd "${jira_url}/secure/CreateIssue!default.jspa" + open_command "${jira_url}/secure/CreateIssue!default.jspa" elif [[ "$1" = "assigned" || "$1" = "reported" ]]; then jira_query $@ else @@ -52,9 +45,9 @@ open_jira_issue () { fi if [[ "x$JIRA_RAPID_BOARD" = "xtrue" ]]; then - $open_cmd "$jira_url/issues/$jira_prefix$1$addcomment" + open_command "$jira_url/issues/$jira_prefix$1$addcomment" else - $open_cmd "$jira_url/browse/$jira_prefix$1$addcomment" + open_command "$jira_url/browse/$jira_prefix$1$addcomment" fi fi } @@ -90,7 +83,7 @@ jira_query () { return 1 fi echo "Browsing issues ${verb} ${preposition} ${jira_name}" - $open_cmd "${jira_url}/secure/IssueNavigator.jspa?reset=true&jqlQuery=${lookup}+%3D+%22${jira_name}%22+AND+resolution+%3D+unresolved+ORDER+BY+priority+DESC%2C+created+ASC" + open_command "${jira_url}/secure/IssueNavigator.jspa?reset=true&jqlQuery=${lookup}+%3D+%22${jira_name}%22+AND+resolution+%3D+unresolved+ORDER+BY+priority+DESC%2C+created+ASC" } alias jira='open_jira_issue' |