diff options
| author | Robby Russell <robby@planetargon.com> | 2015-08-12 21:14:27 -0700 |
|---|---|---|
| committer | Robby Russell <robby@planetargon.com> | 2015-08-12 21:14:27 -0700 |
| commit | b8dbd9bfba261cde572a9cd196dc057719862a6d (patch) | |
| tree | 34887e6b187a29887dde97f113bc0a681df17267 /plugins/jira | |
| parent | 4c1eda114d982ff5f7f7adc396f24c25d3f639d0 (diff) | |
| parent | b760a10cb27e5e17ad32e51ffac3374334fa4888 (diff) | |
| download | zsh-b8dbd9bfba261cde572a9cd196dc057719862a6d.tar.gz zsh-b8dbd9bfba261cde572a9cd196dc057719862a6d.tar.bz2 zsh-b8dbd9bfba261cde572a9cd196dc057719862a6d.zip | |
Merge pull request #4217 from mcornella/standard-open-command
Implement and use a standard, cross-platform open command
Diffstat (limited to 'plugins/jira')
| -rw-r--r-- | plugins/jira/jira.plugin.zsh | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/plugins/jira/jira.plugin.zsh b/plugins/jira/jira.plugin.zsh index ca540c84c..9a8932702 100644 --- a/plugins/jira/jira.plugin.zsh +++ b/plugins/jira/jira.plugin.zsh @@ -11,13 +11,6 @@ # Usage: jira # opens a new issue # jira ABC-123 # Opens an existing issue open_jira_issue () { - local open_cmd - if [[ "$OSTYPE" = darwin* ]]; then - open_cmd='open' - else - open_cmd='xdg-open' - fi - if [ -f .jira-url ]; then jira_url=$(cat .jira-url) elif [ -f ~/.jira-url ]; then @@ -39,7 +32,7 @@ open_jira_issue () { if [ -z "$1" ]; then echo "Opening new issue" - $open_cmd "${jira_url}/secure/CreateIssue!default.jspa" + open_command "${jira_url}/secure/CreateIssue!default.jspa" elif [[ "$1" = "assigned" || "$1" = "reported" ]]; then jira_query $@ else @@ -52,9 +45,9 @@ open_jira_issue () { fi if [[ "x$JIRA_RAPID_BOARD" = "xtrue" ]]; then - $open_cmd "$jira_url/issues/$jira_prefix$1$addcomment" + open_command "$jira_url/issues/$jira_prefix$1$addcomment" else - $open_cmd "$jira_url/browse/$jira_prefix$1$addcomment" + open_command "$jira_url/browse/$jira_prefix$1$addcomment" fi fi } @@ -90,7 +83,7 @@ jira_query () { return 1 fi echo "Browsing issues ${verb} ${preposition} ${jira_name}" - $open_cmd "${jira_url}/secure/IssueNavigator.jspa?reset=true&jqlQuery=${lookup}+%3D+%22${jira_name}%22+AND+resolution+%3D+unresolved+ORDER+BY+priority+DESC%2C+created+ASC" + open_command "${jira_url}/secure/IssueNavigator.jspa?reset=true&jqlQuery=${lookup}+%3D+%22${jira_name}%22+AND+resolution+%3D+unresolved+ORDER+BY+priority+DESC%2C+created+ASC" } alias jira='open_jira_issue' |