diff options
| author | Max Bane <max.bane@gmail.com> | 2012-11-28 02:02:58 -0500 |
|---|---|---|
| committer | Max Bane <max.bane@gmail.com> | 2012-11-28 02:02:58 -0500 |
| commit | 53854754e0d052c41587c7d84b9be7868f31bfe8 (patch) | |
| tree | dde58a78dcfc4e7f687ff7dcedffa4b1a263e86c /plugins/vi-mode | |
| parent | d750e7d9e3b7d04bafc93211f7db4c607ecea19b (diff) | |
| download | zsh-53854754e0d052c41587c7d84b9be7868f31bfe8.tar.gz zsh-53854754e0d052c41587c7d84b9be7868f31bfe8.tar.bz2 zsh-53854754e0d052c41587c7d84b9be7868f31bfe8.zip | |
Revert "Fix to restore bindings after switching to vi-mode"
This reverts commit b609aa0e6c981f2039d777687cb01a84587f6edc -- this commit
was a bad idea, because it makes vi-mode very difficult to use. The default
`bindkey` keybindings are NOT MEANT to coexist with `bindkey -v` Vi mode;
that's why `bindkey -v` clears them in the first place! Restoring all of the
default keybindings after enabling Vi mode, the way the reverted commit did,
causes many collisions between those default keybindings that begin with ESC
and the command-mode-initiating ESC of Vi mode. See Issue 1438 of
robbyrussell/oh-my-zsh. If people have custom keybindings, they should create
them in their ~/.zshrc AFTER enabling the vi-mode plugin and sourcing
oh-my-zsh.sh.
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch master
# Changes to be committed:
# (use "git reset HEAD <file>..." to unstage)
#
# modified: plugins/vi-mode/vi-mode.plugin.zsh
#
Diffstat (limited to 'plugins/vi-mode')
| -rw-r--r-- | plugins/vi-mode/vi-mode.plugin.zsh | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/plugins/vi-mode/vi-mode.plugin.zsh b/plugins/vi-mode/vi-mode.plugin.zsh index d29eb1dda..c47ab7211 100644 --- a/plugins/vi-mode/vi-mode.plugin.zsh +++ b/plugins/vi-mode/vi-mode.plugin.zsh @@ -5,12 +5,7 @@ function zle-line-init zle-keymap-select { zle -N zle-line-init zle -N zle-keymap-select -#changing mode clobbers the keybinds, so store the keybinds before and execute -#them after -binds=`bindkey -L` bindkey -v -for bind in ${(@f)binds}; do eval $bind; done -unset binds # if mode indicator wasn't setup by theme, define default if [[ "$MODE_INDICATOR" == "" ]]; then |